phpBB2Refugees.com Logo
Not affiliated with or endorsed by the phpBB Group

Register •  Login 

Continue the legacy...

Welcome to all phpBB2 Refugees!Wave Smilie

This site is intended to continue support for the legacy 2.x line of the phpBB2 bulletin board package. If you are a fan of phpBB2, please, by all means register, post, and help us out by offering your suggestions. We are primarily a community and support network. Our secondary goal is to provide a phpBB2 MOD Author and Styles area.

[RC] User Selectable Board Width 1.0.1

Goto page 1, 2, 3  Next
 
Search this topic... | Search MOD Development... | Search Box
Register or Login to Post    Index » MOD Development  Previous TopicPrint TopicNext Topic
Author Message
drathbun
Board Member



Joined: 24 Jul 2008

Posts: 653
Location: Texas


flag
PostPosted: Tue Dec 09, 2008 4:02 pm 
Post subject: User Selectable Board Width 1.0.1

This MOD will allow a board owner to set up a series of user-selectable board widths in their profile. The board owner can also set a board width of any specific value, or use the value "100%" to make the layout fluid (full-screen).

This MOD is in use on this site, so no need for a demo link.

A "release candidate" file has been attached to this post. The installation instructions have been validated as far as find targets, but I have not installed it on a vanilla board to test it out. If anyone can help out with testing and bug reports, that would be great. Thanks.



install.txt
 Description:
MOD Installation file (text format)
1.0.1

Download
 Filename:  install.txt
 Filesize:  12.57 KB
 Downloaded:  1057 Time(s)


_________________
phpBBDoctor Blog


Last edited by drathbun on Wed Dec 10, 2008 10:46 pm, edited 2 times in total
Back to top
dondino
Board Member



Joined: 09 Dec 2008

Posts: 144


flag
PostPosted: Wed Dec 10, 2008 2:31 pm 
Post subject: Re: User Selectable Board Width

Hello,
while passing through the installation text I have found this minor mistake:

Code:
#-----[ FIND ]-------------------------------------
# On or about line 306; find text might not be a complete line
#
function display_avatar_gallery(

#
#-----[ IN-LINE FIND ]-------------------------------------
#
)

#
#-----[ IN-LINE BEFORE, ADD ]-------------------------------------
#
, $board_width)


It's clear that you have to leave out the ")" at the end icon_smile.gif

Anyway, I just installed this RC mod in my heavy modded phpbb2 board, and for now it's already working perfectly...
As I have anything to report I will be back here icon_smile.gif

Thanks for this by the way!
Back to top
drathbun
Board Member



Joined: 24 Jul 2008

Posts: 653
Location: Texas


flag
PostPosted: Wed Dec 10, 2008 2:49 pm 
Post subject: Re: User Selectable Board Width

No, the ) is not left out, that's only a partial line find. As far as I can tell, it should be that way. icon_smile.gif
_________________
phpBBDoctor Blog
Back to top
dondino
Board Member



Joined: 09 Dec 2008

Posts: 144


flag
PostPosted: Wed Dec 10, 2008 2:53 pm 
Post subject: Re: User Selectable Board Width

drathbun wrote:
No, the ) is not left out, that's only a partial line find. As far as I can tell, it should be that way. icon_smile.gif

hmm you might be right, but if i follow that codechange I end up with a "))" at the end of the line.

Following that codechange there's this:
Code:
#-----[ FIND ]-------------------------------------
# On or about line 382; find text might not be a complete line
#
$params =

#
#-----[ IN-LINE FIND ]-------------------------------------
#
)

#
#-----[ IN-LINE BEFORE, ADD ]-------------------------------------
#
, 'board_width'

it seems pretty the same situation, but this time correct for me in syntax, because there is not an extra closing parentesis. But its just my point of view anyway! icon_smile.gif
Back to top
drathbun
Board Member



Joined: 24 Jul 2008

Posts: 653
Location: Texas


flag
PostPosted: Wed Dec 10, 2008 2:57 pm 
Post subject: Re: User Selectable Board Width

Ok, I will review the changes again, thanks. What I do when I create those is I validate the "find" targets with a script, but I don't actually install the MOD. So if there is an edit that causes a problem, it won't be found until an actual install is run.

I will test / upload a new set of install instructions if it needs to be fixed. Thanks for testing!

_________________
phpBBDoctor Blog
Back to top
drathbun
Board Member



Joined: 24 Jul 2008

Posts: 653
Location: Texas


flag
PostPosted: Wed Dec 10, 2008 10:41 pm 
Post subject: Re: User Selectable Board Width

Oh, duh, I read your post wrong. Your correction is correct. icon_smile.gif I thought you meant something else.

I will update the code and re-upload the text, thank you.

_________________
phpBBDoctor Blog
Back to top
dondino
Board Member



Joined: 09 Dec 2008

Posts: 144


flag
PostPosted: Fri Dec 12, 2008 12:38 am 
Post subject: Re: User Selectable Board Width 1.0.1

Today I noticed a small issue in my board, with this mod...
while users have absolutely no problem in changing the board width in their own profile, and apply the settings correctly, on the other hand I can't change the "default board width" in the admin control panel.
If i change the default value from there, it doesn't update the database and still remains the default value set initially with the launched sql query (ex. 100%).

Well, there's no problem about that... because I can change that value from phpmyadmin but I just can't figure out why its not working from adminCP... I have checked again all the modifications with the install.txt and I made everything correct...

Can you point me on what do I have to check better, in the code, in order to make the admincp default board width function to update the database as it should?

Thanks
Back to top
drathbun
Board Member



Joined: 24 Jul 2008

Posts: 653
Location: Texas


flag
PostPosted: Fri Dec 12, 2008 1:18 am 
Post subject: Re: User Selectable Board Width 1.0.1

Yeah, the insert statement is probably wrong. I will check it and post a fix.

[Edit]

Nope, the insert is fine, is the template and admin page that are incorrect. Open your board_config_body.tpl and find this:
Code:
default_board_width

and replace it with this:
Code:
phpbbdoctor_default_board_width

I think that's the only change you would have to make. If you don't mind testing that and letting me know, I will update the install file accordingly.

[Edit 2]
No, that's not the only change. I will be back in a bit with a better fix. icon_redface.gif

_________________
phpBBDoctor Blog
Back to top
dondino
Board Member



Joined: 09 Dec 2008

Posts: 144


flag
PostPosted: Fri Dec 12, 2008 2:01 pm 
Post subject: Re: User Selectable Board Width 1.0.1

drathbun wrote:

No, that's not the only change. I will be back in a bit with a better fix. icon_redface.gif

Take your time with the mod. I'm here also for testing purposes icon_smile.gif
Back to top
dondino
Board Member



Joined: 09 Dec 2008

Posts: 144


flag
PostPosted: Fri Sep 11, 2009 2:20 pm 
Post subject: Re: User Selectable Board Width 1.0.1

drathbun wrote:
No, that's not the only change. I will be back in a bit with a better fix. icon_redface.gif

drathbun,
I am still waiting for the better fix... icon_redface.gif
Back to top
drathbun
Board Member



Joined: 24 Jul 2008

Posts: 653
Location: Texas


flag
PostPosted: Fri Sep 11, 2009 6:44 pm 
Post subject: Re: User Selectable Board Width 1.0.1

Ah, well, I have no idea what I had in mind. icon_smile.gif icon_lol.gif I will have to go back and look at the code and see what (if any) changes I made.
_________________
phpBBDoctor Blog
Back to top
dondino
Board Member



Joined: 09 Dec 2008

Posts: 144


flag
PostPosted: Sat Dec 25, 2010 2:39 pm 
Post subject: Re: User Selectable Board Width 1.0.1

2 years later...

still waiting for a fix icon_biggrin.gif

I can't change the board width from the Admin CP icon_smile.gif
can someone have a look into this mod?
Back to top
dondino
Board Member



Joined: 09 Dec 2008

Posts: 144


flag
PostPosted: Sat Jun 11, 2011 7:40 am 
Post subject: Re: User Selectable Board Width 1.0.1

Still waiting!
2 years and half icon_biggrin.gif
But i'm confident, and I have a looooooooot of patience icon_wink.gif
Back to top
Salvatos
Board Member



Joined: 19 Feb 2009

Posts: 414
Location: Québec


flag
PostPosted: Sat Jun 11, 2011 4:04 pm 
Post subject: Re: User Selectable Board Width 1.0.1

I had a good look at the MOD and I can't figure out anything other than the input name 'phpbbdoctor_default_board_width' drathbun had already pointed out... really strange.
Back to top
dondino
Board Member



Joined: 09 Dec 2008

Posts: 144


flag
PostPosted: Sun Jun 12, 2011 9:34 pm 
Post subject: Re: User Selectable Board Width 1.0.1

Salvatos wrote:
I had a good look at the MOD and I can't figure out anything other than the input name 'phpbbdoctor_default_board_width' drathbun had already pointed out... really strange.

Oh Salvatos! Thanks for replying...
have you tested this "little" mod as well?

To change default resolution I have to do it from the database directly, cause its not possible from the phpbb admin side icon_smile.gif

Maybe its just the input name too long?? Who knows... icon_rolleyes.gif
But it would be nice someday to be able to change this resolution from its admin panel icon_biggrin.gif
Back to top
Display posts from previous:   
Register or Login to Post    Index » MOD Development  Previous TopicPrint TopicNext Topic
Page 1 of 3 All times are GMT
Goto page 1, 2, 3  Next
 
Jump to:  

Index • About • FAQ • Rules • Privacy • Search •  Register •  Login 
Not affiliated with or endorsed by the phpBB Group
Powered by phpBB2 © phpBB Group
Generated in 0.0187 seconds using 17 queries. (SQL 0.0028 Parse 0.0028 Other 0.0131)
phpBB Customizations by the phpBBDoctor.com
Template Design by DeLFlo and MomentsOfLight.com Moments of Light Logo