phpBB2Refugees.com Logo
Not affiliated with or endorsed by the phpBB Group

Register •  Login 

Continue the legacy...

Welcome to all phpBB2 Refugees!Wave Smilie

This site is intended to continue support for the legacy 2.x line of the phpBB2 bulletin board package. If you are a fan of phpBB2, please, by all means register, post, and help us out by offering your suggestions. We are primarily a community and support network. Our secondary goal is to provide a phpBB2 MOD Author and Styles area.

I'm going to fork phpbb2

Goto page 1, 2  Next
 
Search this topic... | Search phpBB2 Discussion... | Search Box
Register or Login to Post    Index » phpBB2 Discussion  Previous TopicPrint TopicNext Topic
Author Message
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Mon Sep 22, 2014 9:38 am 
Post subject: I'm going to fork phpbb2

I like phpbb2 and I will continue to use it, but I know that it needs improvement in many areas and nobody will do that for me, so I've decided to fork phpbb2, it seems better idea than starting from scratch (for me that is not doable, not useful either) or just patching here and there (not good for long term).

I don't plan to maintain compatibility, I'll adapt it to my likes/needs and I won't be using current mods, so probably it won't be of any use to people still using phpbb2, maybe not even to anyone else. But I'll do it anyway, just in case someone will still appreciate a simpler old-school forum.

Yeah, I know how big this task is, I've been thinking about it for some time now. Not that I'm exactly a good programmer but I think I can do it (yeah, I'm not the first one that intends to fork phpbb2), and it will also be a good way to improve my skills.

Give me a year or two, and wish me luck!

I prefer to do this "cleaning and updating" myself, once I release the code if someone wants to help it will be much appreciated.

All ideas are welcomed.
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Wed Sep 24, 2014 6:09 pm 
Post subject: Re: I'm going to fork phpbb2

I know just one little thing, probably I'll call it exos, which means boneless... it will be some kind of spaghetti code, so the name fits it well icon_mrgreen.gif

Sorry, I couldn't resist, I'm too funny icon_rolleyes.gif
Back to top
lumpy burgertushie
Board Member



Joined: 19 Nov 2008

Posts: 224


flag
PostPosted: Thu Sep 25, 2014 11:56 pm 
Post subject: Re: I'm going to fork phpbb2

or you could "spoon" phpbb instead of "forking" it.


robert
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Fri Sep 26, 2014 8:52 am 
Post subject: Re: I'm going to fork phpbb2

I see, you are also too funny icon_mrgreen.gif

Fork? Spoon? Probably I shouldn't even touch it with a barge pole and you want me to eat it?

OK, let's continue the fun:
- It won't use a template engine.
- No native search, will use fulltext mysql, or sphinx if installed.
- No oop code apart from mysqli/pdo or sphinx.
- Probably no data cache files, instead will use mysql, or apcu if available.
- I'll remove many features from phpbb2.
- It will be harder to install.

There are more questionable decisions... but enough laughs for today.

I'm open to any (funny or not) suggestions.
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Sat Sep 27, 2014 5:02 pm 
Post subject: Re: I'm going to fork phpbb2

I've replaced the copyright in the header comments, for example this:
Quote:
/***************************************************************************
* index.php
* -------------------
* begin : Saturday, Feb 13, 2001
* copyright : (C) 2001 The phpBB Group
* email : support@phpbb.com
*
* $Id: index.php 5502 2006-01-28 11:13:39Z acydburn $
*
*
***************************************************************************/

/***************************************************************************
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
***************************************************************************/


To this:
Quote:
/**
* @copyright (c) 2014 SuperSecretProjectName
* @copyright (c) 2001-2008 The phpBB Group (phpbb.com)
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*/


Do you think it's fine just like that? Who from phpbb.com may I ask? Any of the team leaders? Marshalrusty? Do I just send him a PM there?


These are all the changes so far... this was the hard part, from here the rest are just trivial icon_mrgreen.gif
Quote:
- Branding: add another copyright line to header.
- Branding: replaced phpbb_clean_username _phpbbcode phpbb_rtrim, phpbb.com (from url examples in bbcode.php), phpbb_realpath, phpbb_ltrim, phpbb_preg_quote, phpbb_db_backup.sql.gz, phpbb_db_backup.sql, www.phpbb.com (from version check) and phpbb_.
- Branding: replaced PHPBB_INSTALLED, IN_PHPBB and PHPBB_VERSION.
- Branding: replace $phpbb_root_path.
- Changed "POST_GROUPS_URL" for "g" for readability.
- Changed "POST_POST_URL" for "p" for readability.
- Changed "POST_USERS_URL" for "u" for readability.
- Changed "POST_FORUM_URL" for "f" for readability.
- Changed "POST_CAT_URL" for "c" for readability.
- Changed "POST_TOPIC_URL" for "t" for readability.
- Removed extension.inc file.
- Removed $phpEx and $starttime variables.
- Import master-phpbb2 branch from github (https://github.com/phpbb/phpbb/tree/master-phpbb2), last commit 8-oct-2008.
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Wed Oct 01, 2014 6:15 am 
Post subject: Re: I'm going to fork phpbb2

Done:
Quote:
Removed code that allowed use of html in posts.


Now I'm in the middle of switching to use a function to read/sanitize inputs, that function is referenced 88 times for now, that's surely less than half done.
Back to top
Jim_UK
Board Member



Joined: 19 Nov 2008

Posts: 556
Location: North West UK


flag
PostPosted: Sat Oct 04, 2014 3:12 pm 
Post subject: Re: I'm going to fork phpbb2

lumpy burgertushie wrote:
or you could "spoon" phpbb instead of "forking" it.


robert


I think there is a real danger that he "will make a meal" of this. icon_lol.gif

Jim
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Tue Oct 07, 2014 4:21 pm 
Post subject: Re: I'm going to fork phpbb2

The question is, will I eat that code or be eaten by it instead? My own words is just what I will eat?
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Tue Oct 07, 2014 4:47 pm 
Post subject: Re: I'm going to fork phpbb2

Done:
Quote:
Added mysqli support


It will have included some features like private messages, quick reply, subforums, country flags, genders, report posts, post approval, birthdays... but it will use a build system so if someone doesn't want to use any of those "official mods" the code needed for those will be removed in that build.

By the way, the private messaging system will be replaced, the new one will just use a forum with special permissions, where only the topic starter and the members he designates in the first post will have access (or mods/admins if a post in that topic is reported) to that topic.
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Sat Oct 11, 2014 1:19 pm 
Post subject: Re: I'm going to fork phpbb2

Done:
Quote:
Use a function to read and clean input
No more register_long_arrays (HTTP_*_VARS)
Will require php 5.4 (or at least no magic quotes or register globals enabled)
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Sat Oct 11, 2014 1:21 pm 
Post subject: Re: I'm going to fork phpbb2

nostro wrote:
Now I'm in the middle of switching to use a function to read/sanitize inputs, that function is referenced 88 times for now, that's surely less than half done.

Yep, that was less than a quarter of the total.
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Sun Oct 12, 2014 3:02 pm 
Post subject: Re: I'm going to fork phpbb2

- Theme configuration no longer saved in db, now it just loads from a config file.
- Same thing with smilies. Maybe it is not very newbie admin friendly (it's not my main objective), but it's not like smilies are changed frequently, and in a text file is easy to add more, or reorder them, just cut+paste.

Code:
$i = 0;
$smilies[$i]['smilies_id'] = $i;
$smilies[$i]['code'] = ':-D';
$smilies[$i]['smile_url'] = 'icon_biggrin.gif';
$smilies[$i]['emoticon'] = 'Very Happy';

$i++;
$smilies[$i]['smilies_id'] = $i;
$smilies[$i]['code'] = ':-)';
$smilies[$i]['smile_url'] = 'icon_smile.gif';
$smilies[$i]['emoticon'] = 'Smile';
...


- I have made viewtopic.php to load using a php template (I mean using no template engine, no template.php). It loads a bit faster, uses less memory, and the code looks relatively clean and safe, so pure php templates will be.
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Sun Oct 19, 2014 1:07 pm 
Post subject: Re: I'm going to fork phpbb2

Done:
- $board_config no longer loaded/saved from/to db.

Next I'll create a new style (this may take some time) and after that I'll add nonces to forms.
Back to top
Vendethiel
Board Member



Joined: 26 Oct 2014

Posts: 81



PostPosted: Sun Oct 26, 2014 2:54 pm 
Post subject: Re: I'm going to fork phpbb2

Instead of storing everything in files, why not just add a caching capacity to the forum? That's what I've done on my premod, and it's blazing fast (~ 4 queries I can't cache on index, would be 3 if I removed ssid)
Back to top
nostro
Board Member



Joined: 16 Jul 2012

Posts: 54


flag
PostPosted: Sun Oct 26, 2014 3:06 pm 
Post subject: Re: I'm going to fork phpbb2

Not everything, just the things that should not change very often and still would be easy to change editing a file... so that's smilies, themes and board config, word censors probably too, and maybe some mods like the flags one will be also be like this.

But yes, I'll add catching to other parts (at least apcu and filesystem will be available), but I'll leave that for now, there are other things I need to do before taking care of that.
Back to top
Display posts from previous:   
Register or Login to Post    Index » phpBB2 Discussion  Previous TopicPrint TopicNext Topic
Page 1 of 2 All times are GMT
Goto page 1, 2  Next
 
Jump to:  

Index • About • FAQ • Rules • Privacy • Search •  Register •  Login 
Not affiliated with or endorsed by the phpBB Group
Powered by phpBB2 © phpBB Group
Generated in 0.0299 seconds using 15 queries. (SQL 0.0027 Parse 0.0010 Other 0.0262)
phpBB Customizations by the phpBBDoctor.com
Template Design by DeLFlo and MomentsOfLight.com Moments of Light Logo