Author |
Message |
drathbun Board Member
Joined: 24 Jul 2008
Posts: 729 Location: Texas
|
Posted: Tue Dec 09, 2008 12:02 pm Post subject: User Selectable Board Width 1.0.1 |
|
|
This MOD will allow a board owner to set up a series of user-selectable board widths in their profile. The board owner can also set a board width of any specific value, or use the value "100%" to make the layout fluid (full-screen).
This MOD is in use on this site, so no need for a demo link.
A "release candidate" file has been attached to this post. The installation instructions have been validated as far as find targets, but I have not installed it on a vanilla board to test it out. If anyone can help out with testing and bug reports, that would be great. Thanks.
Description: |
MOD Installation file (text format) 1.0.1 |
|
Download |
Filename: |
install.txt |
Filesize: |
12.57 KB |
Downloaded: |
2808 Time(s) |
_________________ phpBBDoctor Blog
Last edited by drathbun on Wed Dec 10, 2008 6:46 pm, edited 2 times in total |
|
Back to top |
|
|
dondino Board Member
Joined: 09 Dec 2008
Posts: 144
|
Posted: Wed Dec 10, 2008 10:31 am Post subject: Re: User Selectable Board Width |
|
|
Hello,
while passing through the installation text I have found this minor mistake:
Code: | #-----[ FIND ]-------------------------------------
# On or about line 306; find text might not be a complete line
#
function display_avatar_gallery(
#
#-----[ IN-LINE FIND ]-------------------------------------
#
)
#
#-----[ IN-LINE BEFORE, ADD ]-------------------------------------
#
, $board_width)
|
It's clear that you have to leave out the ")" at the end
Anyway, I just installed this RC mod in my heavy modded phpbb2 board, and for now it's already working perfectly...
As I have anything to report I will be back here
Thanks for this by the way!
|
|
Back to top |
|
|
drathbun Board Member
Joined: 24 Jul 2008
Posts: 729 Location: Texas
|
Posted: Wed Dec 10, 2008 10:49 am Post subject: Re: User Selectable Board Width |
|
|
No, the ) is not left out, that's only a partial line find. As far as I can tell, it should be that way.
_________________ phpBBDoctor Blog |
|
Back to top |
|
|
dondino Board Member
Joined: 09 Dec 2008
Posts: 144
|
Posted: Wed Dec 10, 2008 10:53 am Post subject: Re: User Selectable Board Width |
|
|
drathbun wrote: | No, the ) is not left out, that's only a partial line find. As far as I can tell, it should be that way. |
hmm you might be right, but if i follow that codechange I end up with a "))" at the end of the line.
Following that codechange there's this:
Code: | #-----[ FIND ]-------------------------------------
# On or about line 382; find text might not be a complete line
#
$params =
#
#-----[ IN-LINE FIND ]-------------------------------------
#
)
#
#-----[ IN-LINE BEFORE, ADD ]-------------------------------------
#
, 'board_width' |
it seems pretty the same situation, but this time correct for me in syntax, because there is not an extra closing parentesis. But its just my point of view anyway!
|
|
Back to top |
|
|
drathbun Board Member
Joined: 24 Jul 2008
Posts: 729 Location: Texas
|
Posted: Wed Dec 10, 2008 10:57 am Post subject: Re: User Selectable Board Width |
|
|
Ok, I will review the changes again, thanks. What I do when I create those is I validate the "find" targets with a script, but I don't actually install the MOD. So if there is an edit that causes a problem, it won't be found until an actual install is run.
I will test / upload a new set of install instructions if it needs to be fixed. Thanks for testing!
_________________ phpBBDoctor Blog |
|
Back to top |
|
|
drathbun Board Member
Joined: 24 Jul 2008
Posts: 729 Location: Texas
|
Posted: Wed Dec 10, 2008 6:41 pm Post subject: Re: User Selectable Board Width |
|
|
Oh, duh, I read your post wrong. Your correction is correct. I thought you meant something else.
I will update the code and re-upload the text, thank you.
_________________ phpBBDoctor Blog |
|
Back to top |
|
|
dondino Board Member
Joined: 09 Dec 2008
Posts: 144
|
Posted: Thu Dec 11, 2008 8:38 pm Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
Today I noticed a small issue in my board, with this mod...
while users have absolutely no problem in changing the board width in their own profile, and apply the settings correctly, on the other hand I can't change the "default board width" in the admin control panel.
If i change the default value from there, it doesn't update the database and still remains the default value set initially with the launched sql query (ex. 100%).
Well, there's no problem about that... because I can change that value from phpmyadmin but I just can't figure out why its not working from adminCP... I have checked again all the modifications with the install.txt and I made everything correct...
Can you point me on what do I have to check better, in the code, in order to make the admincp default board width function to update the database as it should?
Thanks
|
|
Back to top |
|
|
drathbun Board Member
Joined: 24 Jul 2008
Posts: 729 Location: Texas
|
Posted: Thu Dec 11, 2008 9:18 pm Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
Yeah, the insert statement is probably wrong. I will check it and post a fix.
[Edit]
Nope, the insert is fine, is the template and admin page that are incorrect. Open your board_config_body.tpl and find this:
Code: | default_board_width |
and replace it with this:
Code: | phpbbdoctor_default_board_width |
I think that's the only change you would have to make. If you don't mind testing that and letting me know, I will update the install file accordingly.
[Edit 2]
No, that's not the only change. I will be back in a bit with a better fix.
_________________ phpBBDoctor Blog |
|
Back to top |
|
|
dondino Board Member
Joined: 09 Dec 2008
Posts: 144
|
Posted: Fri Dec 12, 2008 10:01 am Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
drathbun wrote: |
No, that's not the only change. I will be back in a bit with a better fix. |
Take your time with the mod. I'm here also for testing purposes
|
|
Back to top |
|
|
dondino Board Member
Joined: 09 Dec 2008
Posts: 144
|
Posted: Fri Sep 11, 2009 10:20 am Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
drathbun wrote: | No, that's not the only change. I will be back in a bit with a better fix. |
drathbun,
I am still waiting for the better fix...
|
|
Back to top |
|
|
drathbun Board Member
Joined: 24 Jul 2008
Posts: 729 Location: Texas
|
Posted: Fri Sep 11, 2009 2:44 pm Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
Ah, well, I have no idea what I had in mind. I will have to go back and look at the code and see what (if any) changes I made.
_________________ phpBBDoctor Blog |
|
Back to top |
|
|
dondino Board Member
Joined: 09 Dec 2008
Posts: 144
|
Posted: Sat Dec 25, 2010 10:39 am Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
2 years later...
still waiting for a fix
I can't change the board width from the Admin CP
can someone have a look into this mod?
|
|
Back to top |
|
|
dondino Board Member
Joined: 09 Dec 2008
Posts: 144
|
Posted: Sat Jun 11, 2011 3:40 am Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
Still waiting!
2 years and half
But i'm confident, and I have a looooooooot of patience
|
|
Back to top |
|
|
Salvatos Board Member
Joined: 19 Feb 2009
Posts: 449 Location: Québec
|
Posted: Sat Jun 11, 2011 12:04 pm Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
I had a good look at the MOD and I can't figure out anything other than the input name 'phpbbdoctor_default_board_width' drathbun had already pointed out... really strange.
|
|
Back to top |
|
|
dondino Board Member
Joined: 09 Dec 2008
Posts: 144
|
Posted: Sun Jun 12, 2011 5:34 pm Post subject: Re: User Selectable Board Width 1.0.1 |
|
|
Salvatos wrote: | I had a good look at the MOD and I can't figure out anything other than the input name 'phpbbdoctor_default_board_width' drathbun had already pointed out... really strange. |
Oh Salvatos! Thanks for replying...
have you tested this "little" mod as well?
To change default resolution I have to do it from the database directly, cause its not possible from the phpbb admin side
Maybe its just the input name too long?? Who knows...
But it would be nice someday to be able to change this resolution from its admin panel
|
|
Back to top |
|
|
|